Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip . and $ in section name for subsections when an empty name is given #748

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Skip . and $ in section name for subsections when an empty name is given #748

merged 1 commit into from
Dec 6, 2024

Conversation

bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented Dec 5, 2024

So rather than producing .text. it now produces .text

Fixes #409

@bjorn3
Skip . and $ in section name for subsections when an empty name is given
d18874e 
So rather than producing .text. it now produces .text
philipc
philipc approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@philipc philipc merged commit 9276955 into gimli-rs:master Dec 6, 2024
10 checks passed
@bjorn3 bjorn3 deleted the subsection_empty_name branch December 6, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipc philipc philipc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

write/elf: Allow disabling unique names for subsection
2 participants
@bjorn3 @philipc