Intro rewrites #266
Merged
Intro rewrites #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved to Advanced section. It's now a code-walking macro.
Allow more types in discard comments. Clarify some cond cases and separator comments.
ENV is no longer MappingProxyType. Macros can now theoretically cause expansion environment mutations at expansion time.
In a couple of places where it would help. It was fewer than expected.
Previously a slice. The method wasn't available until Python 3.9.
This doesn't work correctly if the module itself is a package. But the __init__ file is not supposed to be compiled, because it's supposed to have the transpile call in the first place. This is not a serious limitation, because `__init__.py` can do an `import *` from a Lissp module imported after the transpile.
And some minor refactoring.
Use more consistent exception message style
Defaults to caller's globals, like eval() and exec().
Fix invalid escape sequence
Different repr, but essentially the same answer on the GitHub workflow runner.
I'm also skipping black formatting in a few areas, including readerless mode code, which has different rules.
This fixes a serious bug in how gensym hashes were generated.
Test gensyms for reproducible builds Test equal gensyms in same template Test successive gensyms unequal Test gensyms include __name__ in hash Test subrepl tag
'quoted was partially blue.
|
Looks like doc and test changes improved coverage significantly. There are still some more lines I want to cover. #259 should help cover This one is in a good state now. I feel like I need to sync up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked the Whirlwind Tour quite a bit.
Upgraded to Python 3.10, since it's already October. Resolves #261.
Did some code cleanup along with that.
Fixed various bugs discovered from carefully reading the docs, including a serious one involving gensym hash data getting reset too soon. I've added tests for that one.