Skip to content

Commit

Permalink
Merge pull request lxc#4370 from simondeziel/no-upstart
Browse files Browse the repository at this point in the history
Remove support for upstart
  • Loading branch information
stgraber authored Nov 27, 2023
2 parents 9c1d70e + abffab4 commit b425c78
Show file tree
Hide file tree
Showing 10 changed files with 1 addition and 174 deletions.
20 changes: 0 additions & 20 deletions config/init/upstart/lxc-instance.conf

This file was deleted.

8 changes: 0 additions & 8 deletions config/init/upstart/lxc-net.conf.in

This file was deleted.

74 changes: 0 additions & 74 deletions config/init/upstart/lxc.conf.in

This file was deleted.

24 changes: 0 additions & 24 deletions config/init/upstart/meson.build

This file was deleted.

17 changes: 0 additions & 17 deletions doc/ja/lxc.container.conf.sgml.in
Original file line number Diff line number Diff line change
Expand Up @@ -597,23 +597,6 @@ by KATOH Yasufumi <karma at jazz.email.ne.jp>
現時点では、以下のネットワーク仮想化のタイプが使えます:
</para>

<para>
<!--
<option>none:</option> will cause the container to share
the host's network namespace. This means the host
network devices are usable in the container. It also
means that if both the container and host have upstart as
init, 'halt' in a container (for instance) will shut down the
host. Note that unprivileged containers do not work with this
setting due to an inability to mount sysfs. An unsafe workaround
would be to bind mount the host's sysfs.
-->
<option>none:</option> ホストのネットワーク名前空間を共有します。
これにより、ホストのネットワークデバイスをコンテナ内で使うことが可能になります。
もしコンテナもホストも init として upstart を使っている場合、(例えば) コンテナ内で 'halt' を実行すると、ホストがシャットダウンしてしまうことにもなります。
非特権コンテナでは、sysfs をマウントできないので、この設定は動作しません。この問題に対する回避策は、ホストの sysfs を bind マウントすることです。ただしこの回避策は安全ではありません。
</para>

<para>
<!--
<option>empty:</option> will create only the loopback
Expand Down
13 changes: 0 additions & 13 deletions doc/ko/lxc.container.conf.sgml.in
Original file line number Diff line number Diff line change
Expand Up @@ -447,19 +447,6 @@ by Sungbae Yoo <sungbae.yoo at samsung.com>
지정 가능한 형태는 아래와 같다.
</para>

<para>
<!--
<option>none:</option> will cause the container to share
the host's network namespace. This means the host
network devices are usable in the container. It also
means that if both the container and host have upstart as
init, 'halt' in a container (for instance) will shut down the
host.
-->
<option>none:</option> 호스트의 네트워크 네임스페이스를 공유한다. 이렇게 하면 호스트의 네트워크 장치를 컨테이너 내에서 사용가능하다.
컨테이너와 호스트 둘다 init에서 upstart를 사용하는 경우, (예를 들어) 컨테이너에서 'halt'를 하면, 호스트의 것도 종료된다.
</para>

<para>
<!--
<option>empty:</option> will create only the loopback
Expand Down
11 changes: 0 additions & 11 deletions doc/lxc.container.conf.sgml.in
Original file line number Diff line number Diff line change
Expand Up @@ -452,17 +452,6 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
Currently, the different virtualization types can be:
</para>

<para>
<option>none:</option> will cause the container to share
the host's network namespace. This means the host
network devices are usable in the container. It also
means that if both the container and host have upstart as
init, 'halt' in a container (for instance) will shut down the
host. Note that unprivileged containers do not work with this
setting due to an inability to mount sysfs. An unsafe workaround
would be to bind mount the host's sysfs.
</para>

<para>
<option>empty:</option> will create only the loopback
interface.
Expand Down
5 changes: 0 additions & 5 deletions hooks/ubuntu-cloud-prep
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,6 @@ prep() {
error "${0##*}: usage failed, continuing with defaults"
fi

[ "$create_etc_init" -eq 0 ] ||
echo "#upstart needs help for overlayfs (LP: #1213925)." > \
"$root_d/etc/init/.overlayfs-upstart-helper" ||
{ error "failed to create /etc/init in overlay"; return 1; }

local seed_d=""
seed_d="$root_d/var/lib/cloud/seed/nocloud-net"

Expand Down
1 change: 0 additions & 1 deletion meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -886,7 +886,6 @@ subdir('config/etc')
subdir('config/init/common')
subdir('config/init/systemd')
subdir('config/init/sysvinit')
subdir('config/init/upstart')
if want_selinux
subdir('config/selinux')
endif
Expand Down
2 changes: 1 addition & 1 deletion meson_options.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ option('examples', type: 'boolean', value: 'true',

# was --init-script in autotools
option('init-script', type : 'array',
choices : ['systemd', 'sysvinit', 'upstart'], value : ['systemd'],
choices : ['systemd', 'sysvinit'], value : ['systemd'],
description : 'init script')

# was --systemd-unidir in autotools
Expand Down

0 comments on commit b425c78

Please sign in to comment.