Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reproduce bug #1619

Closed
wants to merge 1 commit into from
Closed

Conversation

zewa666
Copy link
Contributor

@zewa666 zewa666 commented Jul 24, 2024

!!!DO NOT MERGE, JUST FOR ERROR REPRODUCTION AND SEEING IT IN STACKBLITZ!!!

Here's the repro of #1618.
if you take a look at the example12 you'll notice that the duration column now has a custom editor in use. If you change the value of a duration cell, you'll notice that the cost column should be updated to 1234657 as well after cell leave.

If you do the same via the composite editor however, that's not happening.

Copy link

stackblitz bot commented Jul 24, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (0c2aca8) to head (c7c508c).
Report is 230 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1619    +/-   ##
=======================================
  Coverage    99.8%   99.8%            
=======================================
  Files         198     198            
  Lines       21796   21796            
  Branches     7304    7023   -281     
=======================================
  Hits        21735   21735            
- Misses         55      61     +6     
+ Partials        6       0     -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding marked this pull request as ready for review September 10, 2024 22:11
@ghiscoding
Copy link
Owner

ghiscoding commented Sep 10, 2024

I was trying to update and rebase the PR, I've never done that, but I guess it's only doable by the author of the PR? I'd really like to know if there's a 1-click way of doing a rebase/force push to the PR to make in sync with latest code in master.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/keeping-your-pull-request-in-sync-with-the-base-branch

Similar to what Renovate does anytime its open PR needs to be rebase, I'm just curious to know how this is done

image

@ghiscoding ghiscoding marked this pull request as draft September 10, 2024 22:18
@zewa666 zewa666 closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants