Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Vulkan SDK #6955

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Update Vulkan SDK #6955

merged 2 commits into from
Jan 21, 2025

Conversation

cwfitzgerald
Copy link
Member

No description provided.

@cwfitzgerald cwfitzgerald requested a review from a team as a code owner January 20, 2025 05:47
@cwfitzgerald cwfitzgerald marked this pull request as draft January 20, 2025 05:54
Wumpf
Wumpf approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but not to ci hum

@cwfitzgerald
Copy link
Member Author

Yeah we have an issue this catches, need to file an issue about it and figure out what to do

@cwfitzgerald
Copy link
Member Author

Silencing the error until KhronosGroup/Vulkan-ValidationLayers#9276 is discussed, letting us move forward.

@cwfitzgerald cwfitzgerald marked this pull request as ready for review January 21, 2025 00:04
@cwfitzgerald cwfitzgerald enabled auto-merge (squash) January 21, 2025 00:05
@cwfitzgerald cwfitzgerald merged commit 04e40dd into gfx-rs:trunk Jan 21, 2025
31 checks passed
@cwfitzgerald cwfitzgerald deleted the cw/update-sdk branch January 21, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwfitzgerald @Wumpf