Standalone Example Infrastructure #6858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
force-pushed
the
cw/standalone-examples
branch
4 times, most recently
from
70a3cb6 to
e82b409
Compare
nical
approved these changes
Jan 20, 2025
cwfitzgerald
commented
Jan 20, 2025
|
There's actually an issue with this anyway, breaking changes wont' compile in the cargo-generate job. Let me fix this |
cwfitzgerald
force-pushed
the
cw/standalone-examples
branch
2 times, most recently
from
23364fb to
b816249
Compare
|
You might consider a naming convention that will sort nicely and allow for more than nine sorted examples. e.g. |
cwfitzgerald
force-pushed
the
cw/standalone-examples
branch
from
b816249 to
798f2f6
Compare
|
Current plan was like 3 standalone examples, but chucking a 0 on there wouldn't hurt, we definnitely won't hit 99. Thanks @aloucks |
cwfitzgerald
force-pushed
the
cw/standalone-examples
branch
from
798f2f6 to
67e56ab
Compare
Fix Generate Fix? 17th Time's The Charm Fix Build See Eye Docs Victory Tabular Formatting Formating3
cwfitzgerald
force-pushed
the
cw/standalone-examples
branch
from
67e56ab to
3aa4871
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us a fully standalone hello-compute example and sets up the infrastructure for having more completely standalone examples.
As part of the move, I separated all the existing examples into a separate file. This PR should be reviewed commit by commit, as the first two commits are bookkeeping and removals and the last commit is the new rewritten standalone compute job.
In order to ensure that the extracted examples remain compilable, adds a CI job that uses
cargo-generateto extract the example, then compiles it. This does not ensure that it runs as we'd need infrastructure for that which we don't want to include in the example.