Remove stale references to d3d12 bindings wrapper crate
#6675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While looking through some recent activity for the D3D12 crate, in particular a spelling fix for the crates.io link to `d3d12`, I realized that I completely forgot to remove these references to the now unused and removed `d3d12` crate in gfx-rs#5956.
teoxoy
changed the title
d3d12 bindings wrapper crated3d12 bindings wrapper crate
|
CC @cwfitzgerald for publishing the deprecation note to https://crates.io/crates/d3d12, perhaps? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
windows-rs#5956d3d12crate on crates.io is 404 #6154d3d12crate #6157Description
While looking through some recent activity for the D3D12 crate, in particular a spelling fix for the crates.io link to
d3d12(#6116), I realized that I completely forgot to remove these references to the now unused and removedd3d12crate in #5956.Testing
N/A
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.Further work
In addition the deprecation notice by #6157, merged to the
v22branch, seems to have never been published to crates.io, hence the proposedd3d12-v22.1.1tag has never materialized leaving the unpublishedrepositoryURL invalid.(Furthermore I think the notice could have pointed users to the
windowscrate directly, in addition to referring them there via #5956)