Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D3D12 cleanup #6200

Merged
merged 9 commits into from
Sep 3, 2024
Merged

D3D12 cleanup #6200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
74f6798
[d3d12] refactor buffer/texture creation functions to return resource…
teoxoy Aug 21, 2024
707ba4c
[d3d12] treat failure to populate references to resources as `DeviceE…
teoxoy Aug 21, 2024
fa700ba
move `hal_usage_error` from the vk backend to lib.rs
teoxoy Aug 21, 2024
3ac1304
[d3d12] make `DxgiLib` and `D3D12Lib` methods consistent
teoxoy Aug 21, 2024
bc01df0
[d3d12] simplify `create_factory()` fn
teoxoy Aug 21, 2024
91e97e9
[d3d12] simplify `enumerate_adapters()` fn
teoxoy Aug 21, 2024
33defb4
[d3d12] use windows-rs's bindings for DXC instead of hassle-rs
teoxoy Sep 2, 2024
d2706c8
[wgpu-hal] add null terminations to symbols to avoid reallocation
teoxoy Sep 2, 2024
8429f65
[tests] don't create a new instance/adapter for `DEVICE_LIFETIME_CHEC…
teoxoy Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 26 additions & 90 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ gpu-descriptor = "0.3"
bit-set = "0.8"
gpu-allocator = { version = "0.27", default-features = false }
range-alloc = "0.1"
hassle-rs = "0.11.0"
Copy link
Contributor

@MarijnS95 MarijnS95 Sep 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference, the only reason why hassle-rs cannot use windows-rs as bindings is because the windows-rs maintainers refuse to allow basic Linux support. DirectxShaderConverter works on Linux via the same COM bindings otherwise.

(Either way the abstraction provided by hassle-rs is far from ideal)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found it more straightforward to just use the bindings directly since we have to deal with them for D3D12 anyway.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the abstraction by hassle-rs isn't that useful. It's mostly creating the bindings but we have those now (except not for Linux 😭) in windows-rs.

windows-core = { version = "0.58", default-features = false }

# Gles dependencies
Expand Down
Loading
Loading