-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement F16 support in shaders #5701
base: trunk
Are you sure you want to change the base?
Conversation
I've marked this as ready for review, as the wgpu specific logic is implemented and would be great to start iterating on it. 2 main blockers are:
|
Dogfooding works! Fixed a few bugs in 30e12b5. Still waiting on upstream. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
One thing I'm concerned is that the polyfills we have in some of the backends might not support |
This comment was marked as resolved.
This comment was marked as resolved.
9c6a9b3
to
9f33e0e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make sure that we are properly validating As
casts of matrices, because that code currently assumes that all matrices have the same kind (#6441).
Super awesome work folks, really appreciate it!! 👏 <3 |
Is there an ETA for this to ship? We'd like to support |
same, i love wgpu and use on rio terminal. Please lemme know if I can help any way to ship this feature. Maybe can split some work |
If either of you are using Vulkan or Windows backend, feel free to start testing support for F16 using this branch. I use the Metal backend, implemented enough support so that all my own tests pass. |
Sounds good @FL33TW00D , i actually started testing this branch in Rio already. Regarding starkat99/half-rs#111 I have been thinking in publish a fork to crates io and maintain until your PR get merged |
Done: https://crates.io/crates/half-2 |
68bb221
to
808db24
Compare
@FL33TW00D created a PR raphamorim/rio#875 but having trouble with naga validation
|
Just checked out 808db24 and ran: You forgot to specify the branch in the cargo git dep! |
You are indeed correct, thank you! |
808db24
to
aac66f9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
aac66f9
to
64c94b8
Compare
Getting this over the line is on my list, will probably be next week. |
64c94b8
to
e68c86e
Compare
I've resolved conflicts with the latest |
e68c86e
to
16a41a2
Compare
8192315
to
d4909a2
Compare
I have split the hex parsing task into a different work item to follow this. See #7046. |
d4909a2
to
d57584d
Compare
Connections
enable …;
that reports nice errors #6424.enable
directive #5476.Checklist for merge-ability
hexf_parse f16 support: https://github.com/lifthrasiir/hexf. This one won't be fun. Did some work on it here: lifthrasiir/hexf@master...FL33TW00D:hexf:feature/f16 .Deferred to Implement Parsing of Hexadecimal F16 #7046Additional context
F16 is available in >=SM6.2: https://github.com/microsoft/DirectXShaderCompiler/wiki/16-Bit-Scalar-Types