Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation to iOS failed #2991

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Fix compilation to iOS failed #2991

merged 1 commit into from
Sep 3, 2019

Conversation

jinleili
Copy link

@jinleili jinleili commented Sep 3, 2019

Fixes wgpu#315
PR checklist:

  • make succeeds (on *nix)
  • make reftests succeeds
  • tested examples with the following backends:metal
  • rustfmt run on changed code

Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
bors r+

bors bot added a commit that referenced this pull request Sep 3, 2019
2991: Fix compilation to iOS failed r=kvark a=grenlight

Fixes wgpu#315
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [x] tested examples with the following backends:metal
- [ ] `rustfmt` run on changed code


Co-authored-by: li jinlei <[email protected]>
@bors
Copy link
Contributor

bors bot commented Sep 3, 2019

Build failed

@kvark
Copy link
Member

kvark commented Sep 3, 2019

bors retry

bors bot added a commit that referenced this pull request Sep 3, 2019
2991: Fix compilation to iOS failed r=kvark a=grenlight

Fixes wgpu#315
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [x] tested examples with the following backends:metal
- [ ] `rustfmt` run on changed code


Co-authored-by: li jinlei <[email protected]>
@bors
Copy link
Contributor

bors bot commented Sep 3, 2019

Build succeeded

@bors bors bot merged commit 4aae475 into gfx-rs:hal-0.3 Sep 3, 2019
@kvark
Copy link
Member

kvark commented Sep 3, 2019

@grenlight this is now published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants