Skip to content

Commit

Permalink
see also testign chapter in dasl internal code review ch
Browse files Browse the repository at this point in the history
  • Loading branch information
sckott committed Aug 9, 2024
1 parent f7b38ed commit 236d780
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions codereview-dasl.qmd
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ At a high level we use the following approach:
- Testing must be used
- With a small team testing is crucial to ensuring software does what it is expected to do, AND facilitates code changes in the future
- When making a code contribution, make sure it is covered by existing tests, or write a new test if not
- See also @sec-testing
- Code should not make it into the codebase without being reviewed, no matter the project status.
- For projects with [**Experimental**](#statuses) status and above, the only way code should make it into the codebase is via pull request, with a review from at least one of the project leads.
- All [**Stable**](#statuses) projects need branch protection on the `main` branch so that the `main` branch can only be updated via pull requests from `dev` or `hotfix-` branches with the approval of a project lead.
Expand Down

0 comments on commit 236d780

Please sign in to comment.