Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser version no longer supported by Slack #436

Merged
merged 1 commit into from
Oct 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/app/manifests/definitions/131.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@
],
"theme_color": "#5559AE",
"scope": "https://teams.live.com",
"extended_scopes": [
"https://*.live.com",
"https://*.office.com",
"https://*.microsoft.com"
],
"bx_legacy_service_id": "microsoft-teams",
"recommendedPosition": "25"
}
2 changes: 1 addition & 1 deletion packages/app/src/session.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ These applications are sensitive to the User-Agent header and have to be recheck
- Google Calendar (18.json)
it's better to remove bx_override_user_agent attribute from manifest before the check to be sure that it's still necessary.
*/
const defaultUserAgent = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.5735.289 Safari/537.36';
const defaultUserAgent = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/129.0.0.0 Safari/537.36';

const getUserAgentForApp = (url: string, currentUserAgent: string): string => {

Expand Down