Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename bx to bxApi #375

Merged
merged 2 commits into from
May 11, 2024
Merged

Rename bx to bxApi #375

merged 2 commits into from
May 11, 2024

Conversation

viktor44
Copy link
Collaborator

What is this PR

window.bx is changed to window.bxApi
Name bx is too short and similar to transpiled code. It interferes with existing code in some apps and causes errors.
Examples of such apps are Google Cloud Console and Firebase Console.

@viktor44 viktor44 requested a review from magne4000 May 10, 2024 06:37
Copy link
Member

@magne4000 magne4000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@viktor44 viktor44 merged commit 9cb16a8 into getstation:main May 11, 2024
3 checks passed
@viktor44 viktor44 deleted the hotfix/bx_rename branch August 25, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants