Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preload script not loading with node integration disabled #310

Closed
wants to merge 1 commit into from
+1 −2
Closed

fix: preload script not loading with node integration disabled #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: preload script not loading with node integration disabled
@magne4000
magne4000 committed Jan 16, 2024
commit 103150fbcbf30f8b1501b1fee12d82cd74e380b2
3 changes: 1 addition & 2 deletions app/applications/Application.tsx
View file
Original file line number Diff line number Diff line change
@@ -400,7 +400,6 @@ class ApplicationImpl extends React.PureComponent {
const tab = this.props.tab;
const useNativeWindowOpen = !this.props.notUseNativeWindowOpen;
const tabUrl = tab.get('url', '');
const nodeIntegrationEnabled = tabUrl.startsWith('station://')

const {
applicationId, applicationName, applicationIcon, themeColor, manifestURL,
@@ -464,7 +463,7 @@ class ApplicationImpl extends React.PureComponent {
onDidFailLoad={this.handleDidFailLoad}
onDomReady={this.handleDomReady}
onCrashed={this.handleWebcontentsCrashed}
webpreferences={`allowRunningInsecureContent=true,nativeWindowOpen=${useNativeWindowOpen},contextIsolation=false,nodeIntegration=${nodeIntegrationEnabled}`}
webpreferences={`allowRunningInsecureContent=true,nativeWindowOpen=${useNativeWindowOpen},contextIsolation=false,nodeIntegration=true`}
/>

</div>