Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python2-ordered-set: Add at 3.1.1 #3057

Merged
merged 1 commit into from
Jun 23, 2024
Merged

python2-ordered-set: Add at 3.1.1 #3057

merged 1 commit into from
Jun 23, 2024

Conversation

sheepman4267
Copy link
Member

Summary
This is an old version of the PyPI ordered-set which works with python2. It is required to enable a deterministic install order for some packages in eopkg py2.

Test Plan

  1. Build package from this PR.
  2. Install it.
  3. Run a python REPL.
  4. Type import ordered_set and see that the module is available, even in python2.

Checklist

  • Package was built and tested against unstable

Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why this is only a draft since, at a glance, it looks ready to go in?

@ermo ermo added the State: Approved This request has been approved label Jun 22, 2024
@ermo ermo added this to the Solus 4.6 milestone Jun 22, 2024
@ermo ermo added Topic: Plumbing Core components Priority: High High priority Type: Feature Something can be enhanced. Topic: Tooling Tools and scripts labels Jun 22, 2024
@ermo ermo changed the title python2-ordered-set: Initial inclusion at 3.1.1 python2-ordered-set: Add at 3.1.1 Jun 22, 2024
@sheepman4267
Copy link
Member Author

I'm curious why this is only a draft since, at a glance, it looks ready to go in?

It's a draft for 2 reasons:

  1. The functionality it's needed for is currently still under heavy testing, and we otherwise have a policy to avoid adding additional py2 packages.
  2. I wanted some feedback (and forgot to say so in the PR) on the package name. Traditionally, we've been using python-package for py2 stuff, and python3-package for py3. However, python-ordered-set is already the py3 version, and I don't want to deal with the rename dance over there. I also really didn't want to ship two different versions in that package, so went with the name I did. I think this makes sense, but wanted to confirm it as it's a departure from our standard practice.

@ermo
Copy link
Contributor

ermo commented Jun 23, 2024

I'm curious why this is only a draft since, at a glance, it looks ready to go in?

It's a draft for 2 reasons:

  1. The functionality it's needed for is currently still under heavy testing, and we otherwise have a policy to avoid adding additional py2 packages.

The functionality is necessary for the solus-sc-based py2 pisi code for the epoch prep stuff and after the epoch until solus-sc, pisi and python2 is deprecated and removed from the repo.

It goes in.

  1. I wanted some feedback (and forgot to say so in the PR) on the package name. Traditionally, we've been using python-package for py2 stuff, and python3-package for py3. However, python-ordered-set is already the py3 version, and I don't want to deal with the rename dance over there. I also really didn't want to ship two different versions in that package, so went with the name I did. I think this makes sense, but wanted to confirm it as it's a departure from our standard practice.

python2-ordered-set is explicit. I like explicit. And this will go away soon-ish anyway, as it'll be deprecated at some point after the epoch bump.

@ermo ermo marked this pull request as ready for review June 23, 2024 16:06
@ermo ermo force-pushed the python2-ordered-set branch from bbd4a54 to d05d895 Compare June 23, 2024 21:15
**Summary**
Initial inclusion of an older version of the PyPI ordered-set package,
which works with python2.

It is required to enable a deterministic install order for some packages
in eopkg py2.
@ermo ermo force-pushed the python2-ordered-set branch from d05d895 to 6147c30 Compare June 23, 2024 21:16
@ermo ermo merged commit 1b6f413 into main Jun 23, 2024
1 check passed
@ermo ermo deleted the python2-ordered-set branch June 23, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High High priority State: Approved This request has been approved Topic: Plumbing Core components Topic: Tooling Tools and scripts Type: Feature Something can be enhanced.
Projects
Archived in project
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants