Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proton-vpn-gtk-app #3038

Merged
merged 21 commits into from
Aug 11, 2024
Merged

Add proton-vpn-gtk-app #3038

merged 21 commits into from
Aug 11, 2024

Conversation

malfisya
Copy link
Member

Summary

Resolves #981

Test Plan

Connect to protonvpn server, browse internet, check IP

Checklist

  • Package was built and tested against unstable

@malfisya
Copy link
Member Author

malfisya commented Jun 19, 2024 •
edited
Loading

Still missing python-aiohttp as rundeps . This is quite a rabbithole Resolved

@malfisya malfisya force-pushed the protonvpn branch 6 times, most recently from feee669 to 02aafc4 Compare July 20, 2024 05:02
@malfisya malfisya changed the title Protonvpn Add proton-vpn-gtk-app Jul 20, 2024
@malfisya malfisya marked this pull request as ready for review July 20, 2024 05:04
@malfisya malfisya force-pushed the protonvpn branch 2 times, most recently from 78beffb to 3e4f029 Compare July 20, 2024 06:01
EbonJaeger
EbonJaeger reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it was fun to sort out.

packages/p/proton-vpn-gtk-app/pspec_x86_64.xml Outdated Show resolved Hide resolved
@malfisya
Copy link
Member Author

It was lot of fun. Also version 4.4.2 just released. lol. I will update it after this got merged.

@malfisya
Copy link
Member Author

Turns out python-aiohttp and python-yarl was deprecated. So, I undeprecate it. The version of these package continuing its previous release number, hence checks failed.

@malfisya malfisya requested a review from EbonJaeger July 30, 2024 23:44
@EbonJaeger
Copy link
Member

I just noticed that we have protonvpn-cli, protonvpn-gui, and protonvpn-nm-lib. Does this replace any of those?

@malfisya
Copy link
Member Author

malfisya commented Jul 31, 2024 •
edited
Loading

It technically replace all those packages, as those are unmaintained upstream. But this is totally different app and AFAIK it does not cause conflict. Even if we decide to deprecate those packages, I don't think this package needs replace key.

@malfisya malfisya marked this pull request as draft July 31, 2024 00:07
@malfisya
Copy link
Member Author

Thanks for the reminder @EbonJaeger . Turns out this app is in conflict with all those old app. I will tinker a bit more. Also in consideration, the old apps is still working as expected, while the new app just entered beta. There is some niceties in the new app but I am not sure it is worth it to include this now. I will keep this drafted for now.

malfisya added 8 commits August 8, 2024 11:25
@malfisya
proton-python-client: Housekeeping
16b93a0 
**Summary**

- Add `homepage` key to `package.yml` (Part of #411)
- Add conflicts with `python-proton-core`
@malfisya
protonvpn-nm-lib: Housekeeping
75b01f5 
**Summary**

- Add `homepage` key to `package.yml` (Part of #411)
- Add conflicts with `python-proton-vpn-network-manager`
@malfisya
protonvpn-cli: Housekeeping
629adf9 
**Summary**

- Add `homepage` key to `package.yml` (Part of #411)
- Add conflicts with `proton-vpn-gtk-app`
@malfisya
protonvpn-gui: Housekeeping
a850607 
**Summary**

- Add `homepage` key to `package.yml` (Part of #411)
- Add conflict with `proton-vpn-gtk-app`
@malfisya
Undepecrate python-aiohttp and python-yarl
0058537
@malfisya
python-expandvars: Add at v0.12.0
08c7a76
@malfisya
python-aiosignal: Add at v1.3.1
542b1de
@malfisya
python-frozenlist: Add at v1.4.1
c8e4511
@malfisya malfisya marked this pull request as ready for review August 8, 2024 05:24
@malfisya
Copy link
Member Author

malfisya commented Aug 8, 2024

A few changes:

  • Updated to latest release (4.4.2)
  • Add python-proton-vpn-network-manager-wireguard and python-proton-vpn-killswitch-wireguard
  • Dropped python-proton-vpn-killswitch and python-proton-vpn-connection (Both of them are merged to python-proton-vpn-core-api by upstream)
  • Now this will conflict with proton-python-client, protonvpn-nm-lib, protonvpn-cli, and protonvpn-gui

I think this is ready to be merged now.

EbonJaeger
EbonJaeger approved these changes Aug 11, 2024
View reviewed changes
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@EbonJaeger EbonJaeger merged commit 67531c3 into main Aug 11, 2024
1 check failed
@EbonJaeger EbonJaeger deleted the protonvpn branch August 11, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EbonJaeger EbonJaeger EbonJaeger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Solus
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ProtonVPN v4 client
2 participants
@malfisya @EbonJaeger