feat(autofix): Add status indicator to button #85306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
roaga
commented
Feb 15, 2025
Comment on lines
265
to
266
| {((!organization.hideAiFeatures && | ||
| (aiConfig.hasSummary || aiConfig.needsGenAIConsent)) || |
There was a problem hiding this comment.
this check should catch that we were showing an empty solutions hub in the EU
❌ 7 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Bundle ReportChanges will increase total bundle size by 107.0kB (0.33%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: app-webpack-bundle-array-pushAssets Changed:
Files in
|
jennmueng
reviewed
Feb 18, 2025
Comment on lines
264
to
267
| {((!organization.hideAiFeatures && | ||
| issueTypeConfig.issueSummary.enabled && | ||
| !organization.hideAiFeatures) || | ||
| organization.features.includes('gen-ai-features') && | ||
| getRegionDataFromOrganization(organization)?.name !== 'de') || |
There was a problem hiding this comment.
Can we use useAiConfig here and use areAiFeaturesAllowed from there which should have the DE check? This will make sure we align all our AI conditionals and reduce copied logic
jennmueng
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redoing this PR, added two missing checks, stricter polling, and a test.
