Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(aci): add support for sentry apps for issue alerts in NOA #85218

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

iamrajjoshi
Copy link
Member

last one!

i needed to add detector since we need to check the project to get the sentry_app_installation_uuid from the sentry_app_id and the org.

@iamrajjoshi iamrajjoshi self-assigned this Feb 13, 2025
@iamrajjoshi iamrajjoshi requested a review from a team as a code owner February 13, 2025 23:59
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 14, 2025
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 5 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...engine/handlers/action/notification/issue_alert.py 86.11% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #85218   +/-   ##
=======================================
  Coverage   87.94%   87.94%           
=======================================
  Files        9634     9634           
  Lines      544147   544236   +89     
  Branches    21124    21124           
=======================================
+ Hits       478547   478632   +85     
- Misses      65295    65299    +4     
  Partials      305      305           

@iamrajjoshi iamrajjoshi merged commit 9bd317e into master Feb 14, 2025
49 checks passed
@iamrajjoshi iamrajjoshi deleted the raj/invoke-rule-registry-sentryapp branch February 14, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants