feat(nav): Open feedback in drawer #85217
Merged
+61
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
malwilley
commented
Feb 14, 2025
| ); | ||
| } | ||
|
|
||
| function SidebarContent() { |
There was a problem hiding this comment.
The refactor moves the useCurrentProjectState() into the content so that it's only used when open. This simplifies things a bit and makes it easier to move to the drawer. The only problem is if there is no currentProject, but I don't see how that could be possible? It used to not open anything in that case and now it opens an empty panel instead.
michellewzhang
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #84018
The old navigation sidebar has been the component responsible for displaying the onboarding panels. Since we are moving to a new nav component, I'm going to be moving all the existing onboarding panels over to our new
useDrawer().This does some refactoring to the feedback onboarding (to make the content usable in both) and exports a
useFeedbackOnboarding()hook that is used for the new nav.