Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔍 nit(slo): make slack message_limit_exceeded a halt #84876

Merged
merged 2 commits into from
Feb 10, 2025
Merged

🔍 nit(slo): make slack message_limit_exceeded a halt #84876

merged 2 commits into from
Feb 10, 2025

Conversation

iamrajjoshi
Copy link
Member

@iamrajjoshi iamrajjoshi self-assigned this Feb 10, 2025
@iamrajjoshi iamrajjoshi requested review from a team as code owners February 10, 2025 18:45
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 10, 2025
cathteng
cathteng approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@cathteng cathteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this different from rate limited?

@iamrajjoshi
Copy link
Member Author

how is this different from rate limited?

its similar, but its a special limit for free slack workspaces.
The free version of Slack restricts use for storage and spam, and you may be prevented from sending too many messages or files in a short period of time.

@iamrajjoshi iamrajjoshi enabled auto-merge (squash) February 10, 2025 18:50
@iamrajjoshi iamrajjoshi merged commit 53736cc into master Feb 10, 2025
48 checks passed
@iamrajjoshi iamrajjoshi deleted the raj/make-message-limit-exceeded-slo branch February 10, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cathteng cathteng cathteng approved these changes

Assignees

@iamrajjoshi iamrajjoshi

Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamrajjoshi @cathteng