chore(uptime): Modify unique subscription check constraint to allow us to migrate away from it #84875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to migrate away from it We want to remove the unique subscription constraint. It's getting increasingly complex to maintain it and it breaks in various ways. As a first step, we'll add a migrated column. Once a subscription sets this to `True` then we won't respect the constraint anymore. We'll use this to work on moving subscriptions away from this model.
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #84875 +/- ##
===========================================
+ Coverage 46.38% 87.89% +41.50%
===========================================
Files 9552 9569 +17
Lines 541139 541887 +748
Branches 20887 20887
===========================================
+ Hits 250997 476278 +225281
+ Misses 289802 65269 -224533
Partials 340 340 |
vgrozdanic
reviewed
Feb 10, 2025
| # is a schema change, it's completely safe to run the operation after the code has deployed. | ||
| # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment | ||
|
|
||
| is_post_deployment = False |
There was a problem hiding this comment.
Should this be post deployment migration, in US table has 84k rows, not much, but could still cause a timeout since we need to rebuild the index?
There was a problem hiding this comment.
This should be ok - we have a lock acquisition timeout for adding an index, but not a statement timeout.
|
This PR has a migration; here is the generated SQL for --
-- Add field migrated to uptimesubscription
--
ALTER TABLE "uptime_uptimesubscription" ADD COLUMN "migrated" boolean DEFAULT false NOT NULL;
--
-- Create constraint uptime_uptimesubscription_unique_subscription_check_4 on model uptimesubscription
--
CREATE UNIQUE INDEX CONCURRENTLY "uptime_uptimesubscription_unique_subscription_check_4" ON "uptime_uptimesubscription" ("url", "interval_seconds", "timeout_ms", "method", "trace_sampling", (MD5("headers")), (COALESCE(MD5("body"), ''))) WHERE NOT "migrated";
--
-- Remove constraint uptime_uptimesubscription_unique_subscription_check_3 from model uptimesubscription
--
DROP INDEX CONCURRENTLY IF EXISTS "uptime_uptimesubscription_unique_subscription_check_3"; |
vgrozdanic
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to remove the unique subscription constraint. It's getting increasingly complex to maintain it and it breaks in various ways.
As a first step, we'll add a migrated column. Once a subscription sets this to
Truethen we won't respect the constraint anymore. We'll use this to work on moving subscriptions away from this model.