feat(widget-builder): Make visualize fields draggable for ordering #84814
+954
−515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
narsaynorath
approved these changes
Feb 10, 2025
static/app/views/dashboards/widgetBuilder/components/widgetBuilderSlideout.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #84814 +/- ##
==========================================
- Coverage 87.88% 87.59% -0.29%
==========================================
Files 9564 9661 +97
Lines 541667 546198 +4531
Branches 20862 21494 +632
==========================================
+ Hits 476021 478424 +2403
- Misses 65306 67437 +2131
+ Partials 340 337 -3 |
Bundle ReportChanges will increase total bundle size by 25.12kB (0.08%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: app-webpack-bundle-array-pushAssets Changed:
|
nikkikapadia
deleted the
nikki/feat/draggable-reorder-visualize-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the features we had left to implement was drag and drop ordering of the visualize fields. On any non-bignumber widget will have the draggable feature where there are 2 or more fields.
Here's what it looks like:
Screen.Recording.2025-02-07.at.4.35.09.PM.mov
Fair warning it looks like a lot of code changes but it's mostly whitespace changes. I've created a general sortable component and a "ghost" component to show when dragging.