feat(nav): Move stats to settings #84804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
malwilley
commented
Feb 7, 2025
| @@ -226,16 +225,7 @@ export function PrimaryNavigationItems() { | |||
| </SidebarMenu> | |||
|
|
|||
| <SidebarLink | |||
| to={`/${prefix}/stats/`} | |||
There was a problem hiding this comment.
Removes stats in new nav component
malwilley
commented
Feb 7, 2025
| @@ -695,6 +696,39 @@ function buildRoutes() { | |||
| </Route> | |||
| ); | |||
|
|
|||
| const statsChildRoutes = ( | |||
There was a problem hiding this comment.
Refactor so that we can use the statsChildRoutes in two places
malwilley
commented
Feb 7, 2025
There was a problem hiding this comment.
New wrapper for stats routes to provide redirect from /stats/ -> /settings/stats/ (redirect only happens when feature flag is on)
malwilley
commented
Feb 7, 2025
| @@ -126,6 +126,14 @@ const organizationNavigation: NavigationSection[] = [ | |||
| show: ({organization}) => | |||
| !!organization && organization.features.includes('feature-flag-ui'), | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Adds stats item in settings menu (feature flagged)
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
scttcper
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #84018
As part of the new nav project, we want to locate the
/stats/page inside/settings/stats/.The stats page will remain unchanged if you do not have the new nav feature flag on.