Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flags): Capture flagpole and option automator results using new SDK interfaces #84724

Merged
merged 6 commits into from
Feb 10, 2025

Conversation

cmanallen
Copy link
Member

Upgrades the SDK and removes the old integration code.

@cmanallen cmanallen requested review from a team as code owners February 6, 2025 19:40
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 6, 2025
src/sentry/features/manager.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/features/manager.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #84724      +/-   ##
==========================================
- Coverage   87.88%   87.71%   -0.17%     
==========================================
  Files        9564     9646      +82     
  Lines      541696   545027    +3331     
  Branches    20863    21391     +528     
==========================================
+ Hits       476044   478063    +2019     
- Misses      65312    66627    +1315     
+ Partials      340      337       -3     

@aliu39
Copy link
Member

aliu39 commented Feb 8, 2025

Maybe we should add feature.- prefixes like we do for FE? And option.- for options

@cmanallen
Copy link
Member Author

@michellewzhang If I emit options which are integers or floats or strings how will the front-end respond?

@cmanallen cmanallen merged commit 62a063f into master Feb 10, 2025
51 checks passed
@cmanallen cmanallen deleted the cmanallen/upgrade-sentry-sdk branch February 10, 2025 16:51
@michellewzhang
Copy link
Member

@michellewzhang If I emit options which are integers or floats or strings how will the front-end respond?

what do you mean by options?

@michellewzhang
Copy link
Member

michellewzhang commented Feb 10, 2025

if you're referring to flag evaluation results, the frontend is typed to require a boolean result so i'd have to update that type to avoid breaking things.

@michellewzhang
Copy link
Member

flag types are defined here:

export type FeatureFlag = {flag?: string; result?: boolean};

@cmanallen cmanallen added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Feb 10, 2025
@getsentry-bot
Copy link
Contributor

PR reverted: 05b095b

getsentry-bot added a commit that referenced this pull request Feb 10, 2025
…ing new SDK interfaces (#84724)"

This reverts commit 62a063f.

Co-authored-by: cmanallen <[email protected]>
cmanallen added a commit that referenced this pull request Feb 12, 2025
…sults using new SDK interfaces (#84724)""

This reverts commit 05b095b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants