-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flags): Capture flagpole and option automator results using new SDK interfaces #84724
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #84724 +/- ##
==========================================
- Coverage 87.88% 87.71% -0.17%
==========================================
Files 9564 9646 +82
Lines 541696 545027 +3331
Branches 20863 21391 +528
==========================================
+ Hits 476044 478063 +2019
- Misses 65312 66627 +1315
+ Partials 340 337 -3 |
Maybe we should add |
@michellewzhang If I emit options which are integers or floats or strings how will the front-end respond? |
what do you mean by options? |
if you're referring to flag evaluation results, the frontend is typed to require a boolean |
flag types are defined here: sentry/static/app/types/event.tsx Line 649 in 09c1f7e
|
PR reverted: 05b095b |
…ing new SDK interfaces (#84724)" This reverts commit 62a063f. Co-authored-by: cmanallen <[email protected]>
Upgrades the SDK and removes the old integration code.