-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tempest): add audit log events for tempest client ids #83091
Open
constantinius
wants to merge
4
commits into
master
Choose a base branch
from
constantinius/feat/tempest/add-audit-log-on-client-id-creation-deletion
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(tempest): add audit log events for tempest client ids #83091
constantinius
wants to merge
4
commits into
master
from
constantinius/feat/tempest/add-audit-log-on-client-id-creation-deletion
+62
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add audit log events TEMPEST_CLIENT_ID_ADD/TEMPEST_CLIENT_ID_REMOVE for when tempes client ids are created/deleted.
github-actions
bot
added
the
Scope: Backend
Automatically applied to PRs that change backend components
label
Jan 8, 2025
shellmayr
reviewed
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to add some tests on this to ensure the end-to-end system works as intended, here's an example from a previous PR that tested audit log creation:
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add audit log events TEMPEST_CLIENT_ID_ADD/TEMPEST_CLIENT_ID_REMOVE for when tempes client ids are created/deleted.
Closes https://github.com/getsentry/team-gdx/issues/56