fix(issue-stream): Wait until stats request has finished before saving groups into cache #83073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g groups into cache
github-actions
bot
added
the
Scope: Frontend
malwilley
commented
Jan 8, 2025
|
|
||
| await screen.findByRole('grid', {name: 'Create a search query'}); | ||
| await userEvent.click(getSearchInput()); | ||
| await userEvent.keyboard('foo{enter}'); | ||
|
|
||
| expect( | ||
| await screen.findByText(/We couldn't find any issues that matched your filters/i) |
There was a problem hiding this comment.
This test was actually just wrong before, these changes made it start failing because it should show "No issues match your search" instead
malwilley
commented
Jan 8, 2025
| const {id} = data[0]; | ||
| redirect = `/organizations/${organization.slug}/issues/${id}/`; | ||
| } | ||
| api.request(`/organizations/${organization.slug}/issues/`, { |
There was a problem hiding this comment.
Best to view this diff with "hide whitespace" because there are only a few actual changes here
malwilley
commented
Jan 8, 2025
| @@ -704,14 +672,6 @@ function IssueListOverviewFc({ | |||
| // reload data. | |||
| if (!isEqual(previousRequestParams, requestParams)) { | |||
| fetchData(selectionChanged); | |||
| } else if ( | |||
There was a problem hiding this comment.
I don't think this is necessary anymore, it should react to the URL changing now
scttcper
approved these changes
Jan 8, 2025
malwilley
deleted the
malwilley/fix/issue-stream-overview-cache-on-back
branch
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the refactored component where navigating to an issue and going back to the stream would never load the stats. This is because I started caching when the request completed instead of when the component unmounted, but never waited for the stats request to complete.
requestPromiseinstead ofrequestapi.clear()instead oflastRequestRef.current.cancel()