Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sveltekit): Create bundler plugin env file instead of sentryclirc #675

Merged
merged 2 commits into from
Sep 23, 2024
Merged

fix(sveltekit): Create bundler plugin env file instead of sentryclirc #675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18af2a9
fix(sveltekit): Create bundler plugin env file instead of sentryclirc
lforst Sep 20, 2024
cedde8b
changelog
lforst Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## Unreleased

- fix(sveltekit): Create bundler plugin env file instead of sentryclirc (#675)

## 3.30.0

- feat: Allow passing org and project slug parameters (#671)
Expand Down Expand Up @@ -29,11 +33,14 @@ Work in this release contributed by @MaximAL. Thank you for your contributions!

## 3.26.0

- fix(nextjs): Don't add '.env.sentry-build-plugin' to .gitignore if it's already there (#610)
- fix(nextjs): Don't add '.env.sentry-build-plugin' to .gitignore if it's
already there (#610)
- feat(nextjs): Support all `next.config` file types (#630)
- fix(nextjs): Update instrumentation and example creation logic for app or pages usage (#629)
- fix(nextjs): Update instrumentation and example creation logic for app or
pages usage (#629)
- feat(nextjs): Prompt for `reactComponentAnnotation` (#634)
- fix(nextjs): Add missing Error.getInitialProps calls in Next.js error page snippets (#632)
- fix(nextjs): Add missing Error.getInitialProps calls in Next.js error page
snippets (#632)
- fix/feat: Improve error logging for package installation (#635)
- fix: Properly close open handles (#638)

Expand All @@ -51,7 +58,8 @@ Work in this release contributed by @MaximAL. Thank you for your contributions!

## 3.24.1

- fix(nextjs): Add trailing comma to `sentryUrl` option in `withSentryConfig` template (#601)
- fix(nextjs): Add trailing comma to `sentryUrl` option in `withSentryConfig`
template (#601)

## 3.24.0

Expand Down
4 changes: 2 additions & 2 deletions src/sveltekit/sveltekit-wizard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import * as Sentry from '@sentry/node';
import {
abort,
abortIfCancelled,
addSentryCliConfig,
addDotEnvSentryBuildPluginFile,
askShouldCreateExamplePage,
confirmContinueIfNoOrDirtyGitRepo,
ensurePackageIsInstalled,
Expand Down Expand Up @@ -98,7 +98,7 @@ export async function runSvelteKitWizardWithTelemetry(
alreadyInstalled: sdkAlreadyInstalled,
});

await addSentryCliConfig({ authToken });
await addDotEnvSentryBuildPluginFile(authToken);

const svelteConfig = await traceStep('load-svelte-config', loadSvelteConfig);

Expand Down
Loading