Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): transaction.set_data sets data on TraceContext #739

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

lcian
Copy link
Member

@lcian lcian commented Feb 5, 2025

The Rust SDK currently sets data on transaction.extra when calling transaction.set_data on a Transaction.
This change makes it so that data is instead set on the TraceContext i.e. transaction.context.trace.data as other SDKs do (see getsentry/team-sdks#95).

Required for #733

@lcian lcian marked this pull request as draft February 6, 2025 07:51
@lcian lcian force-pushed the feat/transaction-set-data-sets-context-data branch from 8117ef6 to 214a25f Compare February 6, 2025 10:37
@lcian
Copy link
Member Author

lcian commented Feb 6, 2025

Changed existing APIs that access/mutate Transaction data (used in the tracing integration) to change data attributes (TraceContext.data) instead of transaction.extra.
Changed comments to reflect the new naming convention of "data attributes" to refer to TraceContext.data.
Changed tests as well to match the new API.

@lcian lcian marked this pull request as ready for review February 6, 2025 10:54
@lcian lcian requested a review from Swatinem February 6, 2025 10:54
@lcian lcian marked this pull request as draft February 6, 2025 13:23
Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! its good to have someone who actually knows how all of this is supposed to work within SDKs :-)

@lcian lcian marked this pull request as ready for review February 6, 2025 18:25
@lcian lcian merged commit 3bcdda3 into master Feb 6, 2025
14 checks passed
@lcian lcian deleted the feat/transaction-set-data-sets-context-data branch February 6, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants