fix(metrics): Parse serialized gauge values #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
reviewed
Feb 5, 2024
| fn test_regression_parse_statsd() { | ||
| let payload = "docker.net.bytes_rcvd:27763.20237096717:27763.20237096717:27763.20237096717:27763.20237096717:1|g|#container_id:97df61f5c55b58ec9c04da3e03edc8a875ec90eb405eb5645ad9a86d0a7cd3ee,container_name:app_sidekiq_1,docker_image:ghcr.io/mastodon/mastodon:nightly.2024-02-02-security,docker_network:app_internal_network,git.commit.sha:1726085db5cd73dd30953da858f9887bcc90b958,git.repository_url:https://github.com/mastodon/mastodon,host:aaaa,image_name:ghcr.io/mastodon/mastodon,image_tag:nightly.2024-02-02-security,runtime:docker,short_image:mastodon,source_type_name:System,environment:production|T1707081890"; | ||
| let metric = Metric::parse_statsd(payload).unwrap(); | ||
| assert_eq!(metric.name, "docker.net.bytes_rcvd"); |
There was a problem hiding this comment.
it we really want to preserve "roundtrips" (which this does not do fully), we should check the fully serialized metric.
also no need to put all the tags into this test :-)
There was a problem hiding this comment.
The question for me is also whether we should be more general in parsing: do we want to discard everything but the last value, or would it make sense to parse and preserve them?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #640 +/- ##
==========================================
+ Coverage 73.23% 73.33% +0.09%
==========================================
Files 62 62
Lines 7550 7563 +13
==========================================
+ Hits 5529 5546 +17
+ Misses 2021 2017 -4 |
Swatinem
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gauges are serialized as
last:min:max:sum:count. When parsing a gauge as aMetric, we only want the last value, so we need to take care to discard everything after the first:.See #639.