Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(baggage): Document that caller must check mutable #4010

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

szokeasaurusrex
Copy link
Member

The Baggage class does not enforce mutability. Document this to avoid confusion.


Thank you for contributing to sentry-python! Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.

The `Baggage` class does not enforce mutability. Document this to avoid confusion.
@szokeasaurusrex szokeasaurusrex enabled auto-merge (squash) January 31, 2025 10:38
Copy link

codecov bot commented Jan 31, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
22038 1 22037 5702
View the top 1 failed tests by shortest run time
tests.integrations.aiohttp.test_aiohttp test_span_origin[pyloop]
Stack Traces | 34s run time
.../integrations/aiohttp/test_aiohttp.py:612: in test_span_origin
    (event,) = events
E   ValueError: too many values to unpack (expected 1)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant