Set level based on status code for HTTP client breadcrumbs #4004
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maybe_create_breadcrumbs_from_span
to set thelevel
of the breadcrumb towarning
for the client error range (4xx) and toerror
for server errors (5xx)responses
in multiple places, but they're not actually active (theactivate
decorator is missing) and we're making actual requests outside -- we should clean this upresponses
for stdlib/requests tests since they patch something that we patchhttpx
,stdlib
,requests
,aiohttp
tests for the new behaviorrequests
tests to 3.7+ since in 3.6, the span is finished before the HTTP status is set for some reason...Closes #4000