Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profiling): Continuous profiling sample rate #4002

Merged
merged 7 commits into from
Feb 4, 2025

Conversation

Zylphrex
Copy link
Member

This introduces a new top level setting for the continuous profiling session sample rate. The sample rate is evaluated once at the beginning and is used to determine whether or not the profiler will be run for the remainder of the process.

This introduces a new top level setting for the continuous profiling session
sample rate. The sample rate is evaluated once at the beginning and is used to
determine whether or not the profiler will be run for the remainder of the
process.
Copy link

codecov bot commented Jan 31, 2025

❌ 13 Tests Failed:

Tests completed Failed Passed Skipped
22148 13 22135 5756
View the top 3 failed tests by shortest run time
tests.test_client test_uwsgi_warnings[opt6-missing_flags6]
Stack Traces | 0.275s run time
tests/test_client.py:1331: in test_uwsgi_warnings
    assert len(recwarn) == 1
E   assert 2 == 1
E    +  where 2 = len(WarningsRecorder(record=True))
tests.test_client test_uwsgi_warnings[opt3-missing_flags3]
Stack Traces | 0.278s run time
tests/test_client.py:1336: in test_uwsgi_warnings
    assert not recwarn
E   assert not WarningsRecorder(record=True)
tests.test_client test_uwsgi_warnings[opt2-missing_flags2]
Stack Traces | 0.284s run time
tests/test_client.py:1336: in test_uwsgi_warnings
    assert not recwarn
E   assert not WarningsRecorder(record=True)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see one suggestion

sentry_sdk/profiler/continuous_profiler.py Outdated Show resolved Hide resolved
@Zylphrex Zylphrex merged commit 797e82f into master Feb 4, 2025
151 checks passed
@Zylphrex Zylphrex deleted the txiao/feat/continuous-profiling-sample-rate branch February 4, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants