Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(profiling-node): Ensure E2E tests run for profiling-node #15248

Merged
merged 6 commits into from
Jan 31, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 31, 2025

This test was still skipped. I un-skipped it and actually split this up into dedicated tests for clarity.

Can't get electron to run successfully on CI (works locally for me...) so skipping it for now, until maybe @timfish can figure it out :D

@mydea mydea self-assigned this Jan 31, 2025
@mydea mydea requested review from timfish and Lms24 January 31, 2025 14:18
@mydea mydea marked this pull request as ready for review January 31, 2025 14:18
@mydea mydea merged commit aa38e37 into develop Jan 31, 2025
126 checks passed
@mydea mydea deleted the fn/stop-skipping-profiling-node branch January 31, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants