feat(browser): Add graphqlClientIntegration
#13783
Conversation
|
|
Just wanted to inform about the failing tests:
|
dev-packages/browser-integration-tests/suites/integrations/graphqlClient/xhr/test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I finally found the time to review this in depth. Overall, I really like it, I left some comments with requests for changes. Mostly it is about moving stuff around, and avoiding any graphql-specific code in the "general" places. Also, please note that if you rebase this in develop, there are/will be a bunch of conflicts - this is mostly because the utils package is deprecated and all that code was moved to core.
|
noted, i'll implement the feedback. thanks for the comprehensive review!
will move on with the conflicts if the current implementation checks out |
| @@ -0,0 +1,121 @@ | |||
| import { SENTRY_XHR_DATA_KEY } from '@sentry-internal/browser-utils'; | |||
| import { getBodyString } from '@sentry-internal/replay'; | |||
There was a problem hiding this comment.
@mydea should this util be in the replay package?
There was a problem hiding this comment.
if we use/need it here, I would move it to @sentry-internal/browser-utils, and use it from there both in replay and here!
There was a problem hiding this comment.
otherwise, this will lead to circular dependency issues :)
Signed-off-by: Kaung Zin Hein <[email protected]>
…s other than string - Moved internal `getFetchRequestArgBody` to `browser-utils`. - Added unit tests. Signed-off-by: Kaung Zin Hein <[email protected]>
Signed-off-by: Kaung Zin Hein <[email protected]>
|
i'm not sure what's making the webkit tests flaky for the added integration tests; locally they all pass on consecutive runs via |
- Moved replay-specific `_serializeFormData` to `browser-utils` and added test. Signed-off-by: Kaung Zin Hein <[email protected]>
Signed-off-by: Kaung Zin Hein <[email protected]>
Signed-off-by: Kaung Zin Hein <[email protected]>
Signed-off-by: Kaung Zin Hein <[email protected]>
Signed-off-by: Kaung Zin Hein <[email protected]>
…n-cronic/sentry-javascript into feat/graphqlClientIntegration
|
I can't push changes on your branch, so I opened a PR here: Zen-cronic#1 which should fix the remaining CI issues on your branch! |
…y#15265) Due to a change in the lifecycle of Svelte components in Svelte 5 (using Rune mode), our SDK can no longer leverage the `(before|after)Update` hooks to track component update spans. For v9, this patch therefore disables update tracking by default.
Removes a no longer necessary fallback check that we only needed in SvelteKit 1.26.0 or older. For Kit 2.x, we can rely on the `event.isSubRequest` flag to identify sub vs. actual requests in our request handler. fixes getsentry#15244
…try#15282) - adds a toolbar for cropping and annotations - changes from inline styles to multiple class names in BEM format With annotation option:  Without annotation option (to confirm that it looks the same as before):  Closes getsentry#15252
…etsentry#15288) The debugging ability for Azure Functions when using Azure Static Web Apps is very limited. But as I could see some Sentry-related logs I **think** Sentry is generally initialized. However, server-related logs don't show up in Sentry. This is **probably** because the Azure Function finishes before the error can be sent to Sentry. By adding the Azure environment variable to check whether we should flush with a timeout, this should possibly fix the issue. Logs in Application Insights: 
Signed-off-by: Kaung Zin Hein <[email protected]>
|
all resolved now! |
Resolves #13399
Todo:
Supportfetchspans and testsSupport graphql queries without a nameEnhance breadcrumb datayarn lint) & (yarn test).