This repository has been archived by the owner on Aug 14, 2024. It is now read-only.
fix(environment): restructure subheadings and clarify ingest setup #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
What do you think about moving the "Running the Getsentry Development Server" section to just below "Running the Development Server"? So it'd be 1. Sentry 2. Getsentry 3. Running Siloed Instances I'm guessing it used to be in that order before the siloed instances part got added because the gs part says "Just like running sentry (see above)," but above is now about silos. |
ceorourke
approved these changes
Jul 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subsubheadings 'Frontend Only & Backend Only'/'Enabling HTTPS'/'Ingestion Pipeline (Relay)' are not specific to Getsentry, so it makes more sense for them to be structured under the Sentry subhead.
Additionally clarify which settings should be used when configuring the devserver for error ingestion vs metrics ingestion.