feat(k8s): Adds a helm chart #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes a helm chart or Meli. I created it based on the k8s manifest contributed by @Berndinox. Hopefully that `values.yaml` file I provided sufficiently explains the various knobs to turn. One potential area of improvement would be allowing existing PVCs to be used. Note that this includes the feature I mentioned in getmeli#233 but which also applies to getmeli#238 which is the ability to explicitly list all sites so that the ingress configuration can fetch SSL certificates _for branch host names_. Ideally, this helm chart would be packaged up and shared...somewhere. I'm actually not that well versed in how to host helm charts for open source software. I know there used to be a public registry hosted by Google but then they withdrew support and the landscape got very fragmented. If there _is_ a place to host such a chart, it would be good to publish this there so that an ordinary helm installation could reference it. Not that the `values.yaml` file include the image and tag. This can be customized to run a custom Meli image instead of the official Docker hub image. This closes getmeli#246.
|
This is awesome, you rock @mtiller, thanks so much for all the time spent improving this project! |
|
Hi @mtiller and thanks for your contribution. Unfortunately, since you added the |
|
Just merged it 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes a helm chart or Meli. I created it based on the
k8s manifest contributed by @Berndinox. Hopefully that
values.yamlfile I provided sufficiently explains the various knobs to turn. One
potential area of improvement would be allowing existing PVCs to
be used.
Note that this includes the feature I mentioned in #233 but which
also applies to #238 which is the ability to explicitly list all sites
so that the ingress configuration can fetch SSL certificates
for branch host names.
Ideally, this helm chart would be packaged up and shared...somewhere.
I'm actually not that well versed in how to host helm charts for
open source software. I know there used to be a public registry
hosted by Google but then they withdrew support and the
landscape got very fragmented. If there is a place to host such
a chart, it would be good to publish this there so that an ordinary
helm installation could reference it.
Not that the
values.yamlfile include the image and tag. Thiscan be customized to run a custom Meli image instead of the
official Docker hub image.
This closes #246.