Temporarily disabling shortcut and detour globally to eliminate a con…

…founding variable when trying to determine how well service is working, especially in China
getlantern · Sep 8, 2022 · 73b1144 · 73b1144
1 parent 81e0fe6
commit 73b1144
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 13 deletions.
diff --git a/config/features_test.go b/config/features_test.go
@@ -138,7 +138,7 @@ func TestDetour(t *testing.T) {
 	gl := globalFromTemplate(t)
 	for _, country := range []string{"cn"} {
 		for _, os := range []string{"android", "windows", "darwin", "linux"} {
-			assert.True(t, gl.FeatureEnabled(FeatureDetour, os, common.DefaultAppName, common.Version, 1, false, country), fmt.Sprintf("detour is enabled for %s in %s", os, country))
+			assert.False(t, gl.FeatureEnabled(FeatureDetour, os, common.DefaultAppName, common.Version, 1, false, country), fmt.Sprintf("detour is disabled for %s in %s", os, country))
 		}
 	}
 }
@@ -148,7 +148,7 @@ func TestShortcut(t *testing.T) {
 	for _, country := range []string{"cn", "ir"} {
 		for _, os := range []string{"android", "windows", "darwin", "linux"} {
 			if country != "ir" || os != "android" {
-				assert.True(t, gl.FeatureEnabled(FeatureShortcut, os, common.DefaultAppName, common.Version, 1, false, country), fmt.Sprintf("shortcut is enabled for %s in %s", os, country))
+				assert.False(t, gl.FeatureEnabled(FeatureShortcut, os, common.DefaultAppName, common.Version, 1, false, country), fmt.Sprintf("shortcut is disabled for %s in %s", os, country))
 			}
 		}
 	}

diff --git a/config_v6/features_test.go b/config_v6/features_test.go
@@ -138,7 +138,7 @@ func TestDetour(t *testing.T) {
 	gl := globalFromTemplate(t)
 	for _, country := range []string{"cn"} {
 		for _, os := range []string{"android", "windows", "darwin", "linux"} {
-			assert.True(t, gl.FeatureEnabled(FeatureDetour, os, common.DefaultAppName, common.Version, 1, false, country), fmt.Sprintf("detour is enabled for %s in %s", os, country))
+			assert.False(t, gl.FeatureEnabled(FeatureDetour, os, common.DefaultAppName, common.Version, 1, false, country), fmt.Sprintf("detour is disabled for %s in %s", os, country))
 		}
 	}
 }
@@ -148,7 +148,7 @@ func TestShortcut(t *testing.T) {
 	for _, country := range []string{"cn", "ir"} {
 		for _, os := range []string{"android", "windows", "darwin", "linux"} {
 			if country != "ir" || os != "android" {
-				assert.True(t, gl.FeatureEnabled(FeatureShortcut, os, common.DefaultAppName, common.Version, 1, false, country), fmt.Sprintf("shortcut is enabled for %s in %s", os, country))
+				assert.False(t, gl.FeatureEnabled(FeatureShortcut, os, common.DefaultAppName, common.Version, 1, false, country), fmt.Sprintf("shortcut is disabled for %s in %s", os, country))
 			}
 		}
 	}

diff --git a/embeddedconfig/global.yaml.tmpl b/embeddedconfig/global.yaml.tmpl
@@ -121,15 +121,15 @@ featuresenabled:
       versionconstraints: ">=99.0.0"
     # For building
   ######## New-Style configuration for detour, shortcut and probeproxies. These are disabled by default and have to be enabled in the config. ########
-  detour:
-    - label: cn-detour
-      geocountries: cn
-  shortcut:
-    - label: cn-shortcut
-      geocountries: cn
-    - lable: ir-desktop-shortcut
-      geocountries: ir
-      platforms: windows,darwin,linux
+  #detour:
+  #  - label: cn-detour
+  #    geocountries: cn
+  #shortcut:
+  #  - label: cn-shortcut
+  #    geocountries: cn
+  #  - label: ir-desktop-shortcut
+  #    geocountries: ir
+  #    platforms: windows,darwin,linux
   # probeproxies is not enabled anywhere
   ######## End of New-Style configuration for detour, shortcut and probeproxies ########