experimental approach for localisation of report #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing - some tests use the default theme, some use a custom theme. So you may have to change settings accordingly. Also, would a package like http://nicksnyder.github.io/go-i18n/ help? |
|
i assume that tests are failing, as said, for me it is more a "could this be the right way to do so" discussion, for what I hesitated to open this as a PR. An external package might help, though I have no overview of the impact of introducing such package |
|
@ajoecker This PR is stale for sometime. Is any help required to fix this or can we close this PR. |
|
I think we just scrap it ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #188
This is a first prototyp-ish approach for allowing to externalise the labels in the report to a property file. It is not complete and shall only be used as a basis for discussion on how to solve this.
E.g. there seems to be localisation package for golang, but I do not understand it now completely. Also it seems to add a new external dependency, so I tried to start with a pure internal approach.
Currently there must be a properties file with all labels and the localised string in the html report plugin itself. The user can then specify the env. variable
report_localisationto match a defined properties file. Default isen.This approach would need also to provide a time format to display any time/date correctly.
Feel free to discuss the approach and/or point to better ways