change for the review

getamis · Mar 28, 2019 · 11e4794 · 11e4794
1 parent f9c1a99
commit 11e4794
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/examples/elastikube-cluster/variables.tf b/examples/elastikube-cluster/variables.tf
@@ -29,7 +29,7 @@ variable "project" {
 
 variable "phase" {
   type = "string"
-  default = "phase"
+  default = "test"
   description = "(Optional) phase name, used to compose the resource name"
 }
 

diff --git a/test/elastikube_cluster_test.go b/test/elastikube_cluster_test.go
@@ -129,7 +129,7 @@ func createKubeconfig(t *testing.T, source string, kubeconfig string) (string, e
 	}
 	l, err := f.WriteString(kubeconfig)
 	if err != nil {
-		f.Close()
+		defer f.Close()
 		return "", err
 	}
 	fmt.Println(l, "bytes written successfully")
@@ -167,7 +167,7 @@ func testBastionHost(t *testing.T, terraformOptions *terraform.Options, keyPair
 	command := fmt.Sprintf("echo -n '%s'", expectedText)
 
 	// Verify that we can SSH to the Instance and run commands
-	retry.DoWithRetry(t, description, maxRetries, timeBetweenRetries, func() (string, error) {
+	retry.DoWithRetry(t, description, MaxRetries, TimeBetweenRetries, func() (string, error) {
 
 		actualText, err := ssh.CheckSshCommandE(t, *bastionHost, command)
 
@@ -186,10 +186,10 @@ func testBastionHost(t *testing.T, terraformOptions *terraform.Options, keyPair
 func testKubernetes(t *testing.T, kubectlOptions *k8s.KubectlOptions, exampleFolder string) {
 
 	// It can take several minutes for the Kubernetes cluster to boot up, so retry a few times
-	description := fmt.Sprint("Access Kubernetes cluster")
+	description := "Access Kubernetes cluster"
 
 	// Verify that we can access Kubernetes cluster by kubectl
-	retry.DoWithRetry(t, description, maxRetries, timeBetweenRetries, func() (string, error) {
+	retry.DoWithRetry(t, description, MaxRetries, TimeBetweenRetries, func() (string, error) {
 
 		nodesReady, err := k8s.AreAllNodesReadyE(t, kubectlOptions)