Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add dark mode qr #218

Closed
wants to merge 1 commit into from
Closed

chore: add dark mode qr #218

wants to merge 1 commit into from

Conversation

im-adithya
Copy link
Member

@im-adithya im-adithya requested a review from rolznz December 12, 2024 12:19
@rolznz
Copy link
Contributor

rolznz commented Dec 16, 2024

@im-adithya I think it would be better to have a white background in dark mode (see screenshot in getAlby/hub#892)

It is uglier but we can ensure all apps can scan the QR code (this is the most important)

@im-adithya
Copy link
Member Author

Closing since functionality is more important 👍

@im-adithya im-adithya closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolznz rolznz Awaiting requested review from rolznz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@im-adithya @rolznz