Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: handle min max values in lnurl withdraw #187

Merged
merged 6 commits into from
Dec 23, 2024
Merged

Conversation

im-adithya
Copy link
Member

@im-adithya im-adithya commented Nov 5, 2024

Description

Fixes #159 although it needs some review of the design. This might be also problematic in small screens.

Screenshots

@stackingsaunter
Copy link

stackingsaunter commented Dec 13, 2024

Here's the design:

Some notes:

  • Just redding the amount + always displaying the range and redding it too will be sufficient I think
  • I think we don't need any confirmation with all details when paying to LN address, most wallets don't do it and it's and additional step
  • I'd appreciate any progress to matching the design in this 2 flows (I need to revise other flows a bit), but that can be seperate issue

Send to LN

CleanShot 2024-12-13 at 01 47 51@2x

CleanShot 2024-12-13 at 01 48 05@2x

CleanShot 2024-12-13 at 01 48 15@2x

Witdraw

image

@im-adithya im-adithya merged commit 5a40ba2 into master Dec 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling min / max values for LNURL
2 participants