feat: add push notifications #163
Conversation
reneaaron
force-pushed
the
feat/push-notifications
branch
from
0289ded to
1c6e544
Compare
feat: notification improvements
| @@ -67,6 +69,15 @@ export default function RootLayout() { | |||
| } | |||
| } | |||
|
|
|||
| async function checkAndPromptForNotifications() { | |||
| const isEnabled = useAppStore.getState().isNotificationsEnabled; | |||
| // prompt the user to enable notifications on first open | |||
There was a problem hiding this comment.
is this good UX? CC @reneaaron
|
Could you update the README to instruct devs how to run with expo go (notifications disabled) or natively (with notifications enabled) |
Done! Let me know if there are any changes. Luckily we have ExecutionEnvironment constant, so we can automatically detect if the user is running it in Expo Go and disable notifications. |
| if (!response.ok) { | ||
| errorToast( | ||
| new Error("Failed to deregister push notification subscription"), | ||
| ); |
There was a problem hiding this comment.
Currently if this fails for some reason, then we might have a weird case where some wallets have notifications and some don't, and if they toggle it again (because we do toggle it off even if this fails), it might make it even messier because they will receive 2 notifications since the last one is also active
There was a problem hiding this comment.
I'm thinking of a UI where there can be all wallets with sub-toggles under the main allow notifications toggle, and if for some reason a wallet fails to deregister, it's toggle will still be on for the user to try again, wdyt?
We can do this as a follow up since http-nostr can be considered quite reliable since here it's only http and not relays
Currently it looks like this:
Add a todo about migrating wallet connections using 0.0 version to 1.0
NIP-44 decryption
Other TODOs
Stop notifications in iOS usingWe decided to show notifications for sending as well, so we don't have to wait for this nowusernotifications.filteringentitlement (also needs feat: add filtering option nikwebr/expo-notification-service-extension-plugin#1)Description
Testing
Replace
NOSTR_API_URLto local http-nostr urlRun feat: add endpoint for registering alby go notifications http-nostr#128 and use
ngrok http 8888Copy the ngrok link to NOSTR_API_URL in constants
If running on android, download
google-services.jsonfrom firebase console and add it to the root of your directory and set this in your .env.local:GOOGLE_SERVICES_JSON=./google-services.jsonConnect your device via cable and run yarn install and then
npx expo run:ios --device/npx expo run:android --deviceEnable notifications in settings and receive a transaction to get notified (tapping on the notification also switches to the right wallet and takes you to the transaction screen)