feat(PricingSlot): custom accessors #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PricingSlot has two new props: titleAccessor & priceAccessor, allowing to pass custom price & title components respectively
|
Spamming with PRs here. For a quick check of everything in #11, #10 & #9, you can have a look at coriou/react-pricing-table#develop |
|
@Coriou thanks a ton for this pr and all the updates. I will get to reviewing them today. |
|
Hey, have you had some time to take a look yet ? Thanks |
|
That was fast :) I'll make myself available in Gitter if you need to discuss this or help with merging all the PRs |
Basic Jest test for custom accessors features: "should render without crashing"
Update readme to match new props for PricingSlot
Oops, it's an HTML table - need to use <code /> instead of backticks
|
Thanks for your work! Trying to merge this PR ASAP 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PricingSlot has two new props: titleAccessor & priceAccessor, allowing to pass custom price & title components respectively
Not ready to be merged, but is working. Check the example:
$ npm start # localhost:8080To do: