-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial ICI changes #238
base: dev
Are you sure you want to change the base?
Initial ICI changes #238
Conversation
…_required for sanitize_input_yaml)
…cies, UseScheduler, SchedulerType, DataPathObs, and PythonEnvType/PythonEnvPath
…OSChemEnv for local simulations
- Conda environment activation is no longer the default. Instead, the config file asks the user to specify a path for a file that will activate the Python environment (via `source $PythonEnv`). This better supports users on clusters that don't support conda. - slurm is no longer the default scheduler. UseSlurm has been removed from the config file and been replaced by SchedulerType. Currently two schedulers are supported: slurm and PBS. - To support this transition, we no longer call sbatch ... within the IMI to the extent possible. Instead, we added a utility function submit_job to src/utilities/common.sh that is run as submit_job $SchedulerType <ScriptName> <ScriptArgument(s)> The function then calls either submit_slurm_job or submit_pbs_job. - We also removed the Boolean usage of UseSlurm. We now assume that a scheduler is always used by the IMI.
…laced sbatch with an if/elif/else statement that depends on SchedulerType and adjusts the call to the scheduler within the script (instead of using the utilities/common.sh function submit_job)
… python environment
… variable specified in run_imi.sh
…mulations - Changed default file/folder names from 1ppb to lowbg (low background) - Changed some methane hardcoding (e.g., changed from default 1e-9 low background to a species dependent value, started to change some of the tracer defaults in HEMCO coding
…ode (UseEmisSF/UseOHSF if statemetns and also default analyticalInv setting) that were removed in the jacobian bug fix branch
Hi Hannah, Giving the IMI flexibility to run on different schedulers is great and will help our work at ECCC. We also use PBS Pro but made the changes manually, so this would speed up the process of pulling new IMI updates. Thanks! |
Hi Sabour, Great! If you find that something doesn't work, please feel free to fix it. I haven't done a ton of rigorous testing on this because I don't have much of the methane data downloaded (since I'm applying this to CO2). |
Name: Hannah Nesser
Institution: JPL
Describe the update
This is a set of changes that:
As of now, this is up to date with the dev branch. The changes include the following (though I may have forgotten something).
PBS/SBATCH flexibility:
UseSlurm
[bool] withSchedulerType
[str].submit_job $SchedulerType SaveOutput JobArguments
whereSaveOutput
is a boolean that determines whether or not the output is appended to imi_output.log. It then callssubmit_slurm_job
orsubmit_pbs_job
as appropriate. Note:submit_pbs_job
currently assumes the use of Pleiades and therefore includes a hardcoded "model" keyword that is required by the system.convert_sbatch_to_pbs
to common.sh that is run in the case thatSchedulerType = "PBS"
. This function searches for all files that haveSBATCH
in their header and then iteratively replaces theSBATCH
commands with thePBS
equivalent. This means that any new SBATCH options added to a header should match the formatting in this function or that the sed statement should be expanded to include the new options.Some changes that were needed to make these changes work:
SBATCH -N 1
uses and instead put the node request intosubmit_job
since PBS requires that the number of nodes be assigned only once and that it occur along with CPU requests, etc. in the initial job request.Conda/pip flexibility:
Methane/CO2 flexibility: