csv writer #36
Merged
csv writer #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkirk
commented
May 13, 2022
| ] | ||
| }); | ||
|
|
||
| let expected_output = r#"geometry,address,datetime,incident number,type |
There was a problem hiding this comment.
note the column order here is different from what's listed in the geojson. By default geojson doesn't keep it's properties ordered. The underlying serde_json crate offers this as an optional feature. I opened an issue to discuss exposing it in geojson here: georust/geojson#187
I'm not totally sure we'd want to use it, but it might be a nice option since we have a concept of "property idx" in some data formats.
| } | ||
| } | ||
|
|
||
| impl GeomProcessor for BufferingWktWriter { |
There was a problem hiding this comment.
All this explicit delegation is kind of tedious. But I'm not sure of a better way to embed the output of WktWriter into the CSVWriter.
There was a problem hiding this comment.
I hope these delegations won't be necessary with the event API anymore.
Closed
michaelkirk
added a commit
to michaelkirk/geozero
that referenced
this pull request
Jun 29, 2022
I encountered this with my initial approach (georust#33), and incorporated a work-around in georust#36, but I failed to consistently apply the work-around, so it was still broken for some geometry types.
michaelkirk
added a commit
to michaelkirk/geozero
that referenced
this pull request
Jun 29, 2022
I encountered this with my initial approach (georust#33), and incorporated a work-around in georust#36, but I failed to consistently apply the work-around, so it was still broken for some geometry types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, let's try this again (supercedes #33).
FIXES #24
This is a follow up to #30, but for writing CSV's.