-
Notifications
You must be signed in to change notification settings - Fork 72
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Upgrade to scany/v2 with support for pgx v5 (#94)
Since pgx v5 contains breaking changes (supports go 1.18+ only) this package also needs to have a version bump - v2 Fixes: #88
- Loading branch information
Showing
17 changed files
with
103 additions
and
68 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,24 @@ | ||
# Overview | ||
|
||
Thank you for considering contributing to scany! This file contains contribution guidelines for new issues and pull requests. | ||
|
||
# Contribution guidelines | ||
|
||
## Issues | ||
|
||
Before opening a new issue, please make sure that you have completed all the following steps: | ||
- Read the documentation for the `pgxscan` package (if you use scany with `pgx` library): https://pkg.go.dev/github.com/georgysavva/scany/pgxscan | ||
- Read the documentation for the `sqlscan` package (if you use scany with `database/sql` library): https://pkg.go.dev/github.com/georgysavva/scany/sqlscan | ||
- Read the documentation for the `dbscan` package: https://pkg.go.dev/github.com/georgysavva/scany/dbscan | ||
|
||
- Read the documentation for the `pgxscan` package (if you use scany with `pgx` library): https://pkg.go.dev/github.com/georgysavva/scany/v2/pgxscan | ||
- Read the documentation for the `sqlscan` package (if you use scany with `database/sql` library): https://pkg.go.dev/github.com/georgysavva/scany/v2/sqlscan | ||
- Read the documentation for the `dbscan` package: https://pkg.go.dev/github.com/georgysavva/scany/v2/dbscan | ||
- Search for already existing similar issues on GitHub: https://github.com/georgysavva/scany/issues | ||
|
||
## Pull requests | ||
|
||
### Code correctness | ||
|
||
All code changes must be covered with tests. See https://github.com/georgysavva/scany/wiki/Tests for how to work with scany tests. | ||
|
||
### Code quality | ||
|
||
Make sure to follow Go best practices and stay consistent with the rest of the code. See https://github.com/georgysavva/scany/wiki/Code-quality for details. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,29 @@ | ||
module github.com/georgysavva/scany | ||
module github.com/georgysavva/scany/v2 | ||
|
||
go 1.14 | ||
go 1.18 | ||
|
||
require ( | ||
github.com/cockroachdb/cockroach-go/v2 v2.2.0 | ||
github.com/jackc/pgtype v1.6.2 | ||
github.com/jackc/pgx/v4 v4.10.1 | ||
github.com/stretchr/testify v1.5.1 | ||
github.com/jackc/pgx/v5 v5.0.0 | ||
github.com/stretchr/testify v1.8.0 | ||
) | ||
|
||
require ( | ||
github.com/davecgh/go-spew v1.1.1 // indirect | ||
github.com/gofrs/flock v0.8.1 // indirect | ||
github.com/jackc/pgio v1.0.0 // indirect | ||
github.com/jackc/pgpassfile v1.0.0 // indirect | ||
github.com/jackc/pgservicefile v0.0.0-20200714003250-2b9c44734f2b // indirect | ||
github.com/jackc/puddle/v2 v2.0.0 // indirect | ||
github.com/lib/pq v1.10.0 // indirect | ||
github.com/pkg/errors v0.9.1 // indirect | ||
github.com/pmezard/go-difflib v1.0.0 // indirect | ||
github.com/rogpeppe/go-internal v1.9.0 // indirect | ||
github.com/stretchr/objx v0.4.0 // indirect | ||
golang.org/x/crypto v0.0.0-20220829220503-c86fa9a7ed90 // indirect | ||
golang.org/x/sys v0.0.0-20210823070655-63515b42dcdf // indirect | ||
golang.org/x/text v0.3.7 // indirect | ||
golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 // indirect | ||
gopkg.in/yaml.v3 v3.0.1 // indirect | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.