-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
demo housekeeping updates #61
base: master
Are you sure you want to change the base?
Conversation
21be674
to
41a04a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for these updates.
If you want, you could also replace this script with "docker system prune", which removes unused containers, images and also networks: https://docs.docker.com/reference/cli/docker/system/prune/
@tomkralidis should we also do this on https://github.com/geopython/pygeoapi-examples ? |
+1, updated in 39fd288 as part of this PR. |
+1. I've put forth a PR in geopython/pygeoapi-examples#20 (not sure if there's more that needs updating, feel free to update the PR branch directly). |
Thank you, merged! 👍🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite some PR. In my projects did similar changes going from docker-compose
to docker compose
. Only in the .stop.sh
scripts I use docker compose down --remove-orphans
as one-liner. Maybe this is the same as
docker compose stop
docker compose rm --force
but more 'modern'. Will look later to other stuff....
Thanks @justb4. I've made an update to use |
Maybe I was not clear: |
d779230
to
2e2aea1
Compare
Thanks for the clarification @justb4. PR updated. |
I think the network config at end of all
i.s.o.
|
As you can run local: create a Traefik config file under |
As mentioned in the PR, it is not tested. When I update networks:
default:
name: pygeoapi-network
external: true and try network pygeoapi-network declared as external, but could not be found Is this expected? Is |
I think @justb4 is correct. According to the documentation: https://docs.docker.com/compose/how-tos/networking/#use-a-pre-existing-network Before running docker-compose (on startup scripts):
And then:
|
Indeed, the network is created in the global start.sh script (and removed in stop.sh script) , which in turn is called on e.g. reboot via the installed system service. But you can always create a Docker network manually. |
docker-compose
->docker compose
(also removingversion
and updatingnetworks
setup)