TST: add use_arrow to geopandas tests with sql statement #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendan-ward
reviewed
Oct 3, 2023
There was a problem hiding this comment.
Thanks for working on this @theroggy - 👍 on more arrow tests.
The only issue I'm seeing is the order of operations around getting the arrow stream (has to happen first) vs setting the index of the next feature to read. Did you find that you needed to change that order for the sql tests to work?
…or-geopandas-tests-with-sql-statement
…or-geopandas-tests-with-sql-statement
Closed
… skip bug is fixed in gdal
|
Hmm... the test still fails on gdal 3.8. The PR was merged 4 days ago, is it possible the container used here doesn't contain the fix yet? |
|
The GDAL latest container hasn't been updated in some time (last update 9/16): https://github.com/OSGeo/gdal/pkgs/container/gdal/128542179?tag=ubuntu-small-latest I thought those would be built automatically on merge to GDAL |
…or-geopandas-tests-with-sql-statement
…or-geopandas-tests-with-sql-statement
…or-geopandas-tests-with-sql-statement
theroggy
deleted the
TST-add-use_arrow-for-geopandas-tests-with-sql-statement
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.