m1 bindings and members scattered around #688
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… gjbasegamelayer member
|
what are the 0x0 pads they are useless girl |
|
wait a second those commits were added to the pr? LOL mb i didnt think they would be |
altalk23
requested changes
Aug 8, 2024
test/members/MacOSArm.cpp
Outdated
| GEODE_MEMBER_CHECK(EnterEffectInstance, m_gameObject, 0x18); | ||
| GEODE_MEMBER_CHECK(EnterEffectInstance, m_unkVecInt, 0x20); | ||
|
|
||
| GEODE_MEMBER_CHECK(CountTriggerAction, m_unkVecInt, 0x0); |
There was a problem hiding this comment.
what in the world is this blasphemy
bindings/2.206/Extras.bro
Outdated
| SFXTriggerGameObject* m_sfxTriggerGameObject; | ||
| } | ||
|
|
||
| class EventTriggerInstance { | ||
| PAD = win 0x10; | ||
| PAD = win 0x10, m1 0x0; |
There was a problem hiding this comment.
yeah please do not use pad 0x0 anywhere that just defeats the purpose and it doesnt even work
There was a problem hiding this comment.
the thing is if i dont put them there the members are privated
There was a problem hiding this comment.
that's the problem, i can't see any
…d be added to the pr)
altalk23
force-pushed
the
main
branch
2 times, most recently
from
b719729 to
ed2b709
Compare
|
you know what i think im just going to close this one for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a big one so i'll be perfectly fine with changing anything that looks wrong that i may have mised