Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PB-577: Sanitize kml content #1225

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

PB-577: Sanitize kml content #1225

wants to merge 1 commit into from

Conversation

sommerfe
Copy link
Contributor

@sommerfe sommerfe commented Jan 29, 2025 •
edited by github-actions bot
Loading

Test link

  • The first link (openstreetmap.org) in title, is pointing to http://evil.com/malware.exe -> blocked
  • The JavaScript code in the descprition -> blocked

Before PR:
image

After PR:
image

Test link

@sommerfe sommerfe self-assigned this Jan 29, 2025
@sommerfe sommerfe force-pushed the feat-pb-577-sanitize-kml-content branch from 1994386 to e154eaf Compare January 29, 2025 13:45
@cypress Cypress
Copy link

cypress bot commented Jan 29, 2025 •
edited
Loading

web-mapviewer    Run #4402

Run Properties:  status check failed Failed #4402  •  git commit f93b392327: PB-577: Sanitize kml content
Project web-mapviewer
Branch Review feat-pb-577-sanitize-kml-content
Run status status check failed Failed #4402
Run duration 04m 50s
Commit git commit f93b392327: PB-577: Sanitize kml content
Committer Felix Sommer
View all properties for this run ↗︎
Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 232
View all changes introduced in this branch ↗︎

Tests for review

Failed  tests/cypress/tests-e2e/drawing.cy.js • 1 failed test • e2e/electron/mobile

View Output

Test Artifacts
Drawing module tests > Drawing mode/tools > can create marker/icons and edit them Test Replay Screenshots

@sommerfe sommerfe force-pushed the feat-pb-577-sanitize-kml-content branch from e154eaf to f93b392 Compare January 29, 2025 14:46
@ismailsunni ismailsunni marked this pull request as ready for review February 4, 2025 07:02
@ismailsunni
Copy link
Contributor

I believe this PR already covers the ticket from the issue. Unless I missed somehting, it's ready to be reviewed.

@ismailsunni ismailsunni requested a review from pakb February 4, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakb pakb Awaiting requested review from pakb

At least 1 approving review is required to merge this pull request.

Assignees

@sommerfe sommerfe

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sommerfe @ismailsunni